Messages in this thread |  | | | Date | Thu, 26 Apr 2007 20:48:38 +0100 | | From | Andy Whitcroft <> | | Subject | Re: 2.6.21-rc7-mm2 -- PPC link failure |
| |
Christoph Lameter wrote: > On Thu, 26 Apr 2007, Andy Whitcroft wrote: > >>> But then how important is gcc 3.3 support? >> Well we say 3.2 is the minimum. If we simply return(NULL) or BUG() in > > Oh before I forget > > Gcc 3.3 works just fine on other platforms like i386. This is more likely > a platform issue. If we disable it then only for <= gcc 3.3 on ppc. If > problems crop up with other platforms then we can expand on it.
I was thinking that it would be nasty to have a set of platform specific, compiler specific ifdefs in here. I was more thinking of just making this a BUG for all platforms. This does result in slightly later detection but this is a constant mode only, so any bad use of kmalloc() would be picked up on first boot in testing always.
I think that would be sufficient and safe even against the worst optimiser (none). Plus much less horrible to look at?
-apw - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |