![]() | |||||||||||||
Messages in this thread |
Andrew Morton wrote: > On Wed, 25 Apr 2007 22:45:09 -0700 Randy Dunlap <randy.dunlap@oracle.com> wrote: > >> From: Randy Dunlap <randy.dunlap@oracle.com>>>>> Eliminate 19439 (!!) sparse warnings like:>> include/linux/mm.h:321:22: warning: constant 0xffff810000000000 is so big it is unsigned long >>>> Eliminate 56 sparse warnings like:>> arch/x86_64/kernel/setup.c:248:16: warning: constant 0xffffffff80000000 is so big it is unsigned long >>>> Eliminate 5 sparse warnings like:>> arch/x86_64/kernel/module.c:49:13: warning: constant 0xfffffffffff00000 is so big it is unsigned long >>>> Eliminate 23 sparse warnings like:>> arch/x86_64/mm/init.c:551:37: warning: constant 0xffffc20000000000 is so big it is unsigned long >>>> Eliminate 6 sparse warnings like:>> arch/x86_64/kernel/module.c:49:13: warning: constant 0xffffffff88000000 is so big it is unsigned long >>>> Eliminate 23 sparse warnings like:>> arch/x86_64/mm/init.c:552:6: warning: constant 0xffffe1ffffffffff is so big it is unsigned long >>>> Eliminate 3 sparse warnings like:>> arch/x86_64/kernel/e820.c:186:17: warning: constant 0x3fffffffffff is so big it is long >>>> ...>>>> +#ifdef __ASSEMBLY__>> #define MAXMEM 0x3fffffffffff >> #define VMALLOC_START 0xffffc20000000000 >> #define VMALLOC_END 0xffffe1ffffffffff >> #define MODULES_VADDR 0xffffffff88000000 >> #define MODULES_END 0xfffffffffff00000 >> #define MODULES_LEN (MODULES_END - MODULES_VADDR) >> +#else >> +#define MAXMEM 0x3fffffffffffUL >> +#define VMALLOC_START 0xffffc20000000000UL >> +#define VMALLOC_END 0xffffe1ffffffffffUL >> +#define MODULES_VADDR 0xffffffff88000000UL >> +#define MODULES_END 0xfffffffffff00000UL >> +#define MODULES_LEN (MODULES_END - MODULES_VADDR) >> +#endif >> > > hm, the duplication is unfortunate. Yep. > I wonder if it's worth doing a cpp token-pasting trick to avoid having to > do that. oh. there is already an include/asm-x86_64/const.h that will help with that. I'll try it out. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2007-04-26 06:09 [from the cache] ©2003-2008 | |||||||||||||