Messages in this thread | | | Date | Thu, 26 Apr 2007 14:13:06 +0100 | From | Alan Cox <> | Subject | Re: [PATCH] sworks-agp: Switch to PCI ref counting APIs |
| |
On Wed, 25 Apr 2007 19:21:58 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
> On Mon, 23 Apr 2007 14:51:29 +0100 Alan Cox <alan@lxorguk.ukuu.org.uk> wrote: > > > { > > struct agp_bridge_data *bridge = pci_get_drvdata(pdev); > > > > + pci_dev_put(bridge->dev); > > agp_remove_bridge(bridge); > > agp_put_bridge(bridge); > > + pci_dev_put(serverworks_private.svrwrks_dev) > > + serverworks_private.svrwrks_dev = NULL; > > err, guys?
I merely fixed the code to refcount, the actual code itself is complete bollocks and does exactly what that implies. It also explodes if you ever use the hotplug testing code to simulate a plug or replug and goes completely bonkers if you put two of them in a qemu simulator 8)
Alan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |