Messages in this thread |  | | | From | Andi Kleen <> | | Subject | Re: [PATCH 09/25] xen: Account for time stolen by Xen | | Date | Wed, 25 Apr 2007 20:15:06 +0200 |
| |
On Wednesday 25 April 2007 20:13:34 Jeremy Fitzhardinge wrote: > Andi Kleen wrote: > >> + > >> + do { > >> + state_time = state->state_entry_time; > >> + barrier(); > >> > > > > Should be likely rmb > > We discussed this, and decided that it wasn't necessary. The state is > always updated by the current CPU, so if it changes under our feet it > will be because we were preempted, and so that should shoot down any > speculated reads.
Then the barrier shouldn't be needed at all?
Anyways needs comments
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |