lkml.org 
[lkml]   [2007]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/10] safe_apic_wait_icr_idle - x86_64
Date
On Wednesday 25 April 2007 14:55:12 Fernando Luis Vázquez Cao wrote:
> On Wed, 2007-04-25 at 14:26 +0200, Andi Kleen wrote:
> > > static __inline__ void apic_wait_icr_idle(void)
> > > {
> > > - while (apic_read( APIC_ICR ) & APIC_ICR_BUSY)
> > > + while (apic_read(APIC_ICR) & APIC_ICR_BUSY)
> > > cpu_relax();
> > > }
> > >
> > > +static __inline__ unsigned int safe_apic_wait_icr_idle(void)
> >
> > This should be probably not inline -- too large
> Hello Andi,
>
> Thank you for reviewing the patches. Do you want me to resend the whole
> patch or should I cook a new one that un-inlines the function instead?

I already did that.

Also will apply Keith's suggestion.

-Andi



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-04-25 15:15    [W:0.050 / U:0.828 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site