Messages in this thread | | | Date | Tue, 24 Apr 2007 20:29:07 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH] cfq: get rid of cfqq hash |
| |
On Tue, Apr 24 2007, Jens Axboe wrote: > - if (key != CFQ_KEY_ASYNC) > + if (!is_sync) > cfq_mark_cfqq_idle_window(cfqq); > + else > + cfq_mark_cfqq_sync(cfqq);
Woops, should be
if (is_sync) { cfq_mark_cfqq_idle_window(cfqq); cfq_mark_cfqq_sync(cfqq); }
of course.
> +static struct cfq_io_context * > +cfq_get_io_context_noalloc(struct cfq_data *cfqd, struct task_struct *tsk) > +{ > + struct cfq_io_context *cic = NULL; > + struct io_context *ioc; > + > + ioc = tsk->io_context; > + if (ioc) > + cic = cfq_cic_rb_lookup(cfqd, ioc); > + > + return cic; > +}
I'll change that to just call cfq_cic_rb_lookup(), returning NULL for NULL ioc.
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |