lkml.org 
[lkml]   [2007]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] eHCA: Add "Modify Port" verb
    From
    Date
    Roland Dreier <rdreier@cisco.com> wrote on 23.04.2007 21:20:14:

    > > + if (hipz_h_query_port(shca->ipz_hca_handle, port, rblock) !=
    H_SUCCESS) {
    > > + ehca_err(&shca->ib_device, "Can't query port properties");
    > > + ret = -EINVAL;
    > > + goto modify_port1;
    > > + }
    > > +
    > > + cap = (rblock->capability_mask | props->set_port_cap_mask)
    > > + & ~props->clr_port_cap_mask;
    > > +
    > > + hret = hipz_h_modify_port(shca->ipz_hca_handle, port,
    > > + cap, props->init_type, port_modify_mask);
    >
    > Is this thread-safe? What if two different bits are set at the same
    > time from two different threads? It seems that both calls could get
    > the same result from hipz_h_query_port(), and then the second call to
    > hipz_h_modify_port() would overwrite the first call.

    Yes, you're so right.

    > You could look at the implementation in mthca to see the locking I
    > used there.

    I'll do that, thanks for the hint!

    Joachim

    ---
    Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer
    IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Dev. 2)
    Schoenaicher Strasse 220 -- 71032 Boeblingen -- Germany
    eMail: fenkes@de.ibm.com -- Phone: +49 7031 16 1239
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-24 14:29    [W:0.021 / U:30.380 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site