lkml.org 
[lkml]   [2007]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] powerpc pseries eeh: Convert to kthread API
    From
    Date

    > Further in general it doesn't make sense to grab a module reference
    > and call that sufficient because we would like to request that the
    > module exits.

    Which is, btw, I think a total misdesign of our module stuff, but heh, I
    remember that lead to some flamewars back then...

    Like anything else, modules should have separated the entrypoints for

    - Initiating a removal request
    - Releasing the module

    The former is use did "rmmod", can unregister things from subsystems,
    etc... (and can file if the driver decides to refuse removal requests
    when it's busy doing things or whatever policy that module wants to
    implement).

    The later is called when all references to the modules have been
    dropped, it's a bit like the kref "release" (and could be implemented as
    one).

    If we had done that (simple) thing back then, module refcounting would
    have been much less of a problem... I remember some reasons why that was
    veto'ed but I didn't and still don't agree.

    Ben.


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-24 07:05    [W:0.020 / U:0.164 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site