Messages in this thread | | | Date | Mon, 23 Apr 2007 08:59:57 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH][RFC] PCMCIA support for 8xx using platform devices |
| |
On Mon, Apr 23, 2007 at 10:14:27AM +0400, Vitaly Bordug wrote: > On Sun, 22 Apr 2007 23:49:41 +0200 > Arnd Bergmann wrote: > > > On Sunday 22 April 2007, Vitaly Bordug wrote: > > > This utilizes PCMCIA on mpc885ads and mpc866ads from arch/powerpc. > > > In the new approach, direct IMMR accesses from within drivers/ were > > > totally eliminated, that requires hardware_enable, > > > hardware_disable, voltage_set board-specific functions to be moved > > > over to BSP code section (arch/powerpc/platforms/8xx in 885 case). > > > There is just no way to have both arch/ppc and arch/powerpc > > > approaches to work simultaneously because of that. > > > > Maybe I'm missing a key issue here, but what's the point of adding > > more platform_devices for stuff that is already in the device tree? > > Shouldn't this be made an of_platform_driver instead so you can > > use the existing of_device directly? > > > Was thinking of it but platform_device is better for migration purposes. Hence, > assuming somebody would want to have pcmcia working not bothering to add whole arch/powerpc support, > it can be accomplished quickly.
That's a horrible argument. Please do it properly, and let arch/ppc die as it should. We shouldn't be adding anything to it anymore anyway.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |