| Date | Tue, 24 Apr 2007 11:45:28 +1000 | From | Herbert Xu <> | Subject | Re: [PATCH 22/25] xen: xen-netfront: use skb.cb for storing private data |
| |
On Mon, Apr 23, 2007 at 02:57:00PM -0700, Jeremy Fitzhardinge wrote: > Netfront's use of nh.raw and h.raw for storing page+offset is a bit > hinky, and it breaks with upcoming network stack updates which reduce > these fields to sub-pointer sizes. Fortunately, skb offers the "cb" > field specifically for stashing this kind of info, so use it. > > Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com> > Cc: Herbert Xu <herbert@gondor.apana.org.au> > Cc: Chris Wright <chrisw@sous-sol.org> > Cc: Christian Limpach <Christian.Limpach@cl.cam.ac.uk>
Thanks Jeremy. The patch looks good.
Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|