lkml.org 
[lkml]   [2007]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 03/25] xen: Add nosegneg capability to the vsyscall page notes
    Date
    > + * It should contain:
    > + * hwcap 0 nosegneg
    > + * to match the mapping of bit to name that we give here.

    This needs to be "hwcap 0 nosegneg" to match:

    > +NOTE_KERNELCAP_BEGIN(1, 2)
    > +NOTE_KERNELCAP(1, "nosegneg")
    > +NOTE_KERNELCAP_END

    The actual bits you are using should be fine. (You're intentionally
    skipping bit 0 to work around hold glibc bugs, which you might want to add
    to the comments. Also a comment or perhaps using 1<<1 syntax would make it
    more clear that "2" is the bit mask containing bit 1 and that's why it has
    to be 2, and not because of some other magical property of 2.) But if
    kernel packagers don't write the matching bit number in their ld.so.conf.d
    files, then ld.so.cache lookups won't work right.


    Thanks,
    Roland
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-24 01:33    [W:0.019 / U:3.972 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site