Messages in this thread | | | Date | Fri, 20 Apr 2007 09:21:40 -0500 | From | Robin Holt <> | Subject | Re: [PATCH] ia64 sn xpc: Convert to use kthread API. |
| |
On Fri, Apr 20, 2007 at 08:23:39AM +0200, Jes Sorensen wrote: > Andrew Morton wrote: > >Another driver which should be fully converted to the kthread API: > >kthread_stop() and kthread_should_stop(). > > > >And according to my logs, this driver was added to the tree more than > >a year _after_ the kthread interface was made available. > > > >This isn't good. > > Andrew, > > Per my previous response, I'd prefer to have either Russ or Robin ack > the patch doesn't break before it's pushed to Linus. > > I don't know much about the xpmem and I am not comfortable testing it.
I think this was originally coded with daemonize to avoid issues with reaping children. Dean Nelson can correct me if I am wrong. I assume this patch is going in as part of the set which will make these threads clear themselves from the children list and if that is the case, I can see no issues.
Thanks, Robin - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |