lkml.org 
[lkml]   [2007]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] Char: mxser_new, fix recursive locking
    > Acquire a port lock only if not in_interrupt in some places, because ISR
    > holds the lock yet (and ldisc calls some of driver's routines which tries to
    > acquire it again due to tty->low_latency).

    NAK

    This is the wrong way to do it. If you don't support recursive entry then
    don't use ->low_latency. If you do then ensure you drop the lock before
    you call tty_flip_buffer_push().

    The other way this could be tackled which has some merit is to require
    that line discipline responses coming from a received frame call a new
    tty method so drivers can tell callbacks from arriving data apart from
    other events.

    Alan
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-20 14:11    [W:0.025 / U:1.444 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site