Messages in this thread Patch in this message |  | | | Date | Fri, 20 Apr 2007 14:12:56 +0200 | | From | Jarek Poplawski <> | | Subject | [PATCH] workqueue: cancel_rearming_delayed_work/workqueue usage warning |
| |
Here is my proposal to make things clearer: (this time on 2.6.21-rc7)
CC: David Chinner <dgc@sgi.com> CC: Oleg Nesterov <oleg@tv-sign.ru> Signed-off-by: Jarek Poplawski <jarkao2@o2.pl>
--- diff -Nurp 2.6.21-rc7-/kernel/workqueue.c 2.6.21-rc7/kernel/workqueue.c --- 2.6.21-rc7-/kernel/workqueue.c 2007-04-18 10:14:16.000000000 +0200 +++ 2.6.21-rc7/kernel/workqueue.c 2007-04-20 13:56:51.000000000 +0200 @@ -662,6 +662,8 @@ EXPORT_SYMBOL(flush_scheduled_work); * cancel_rearming_delayed_workqueue - reliably kill off a delayed work whose handler rearms the delayed work. * @wq: the controlling workqueue structure * @dwork: the delayed work struct + * + * WARNING: use only with handlers, which rearm unconditionally with delay > 0 */ void cancel_rearming_delayed_workqueue(struct workqueue_struct *wq, struct delayed_work *dwork) @@ -674,6 +676,8 @@ EXPORT_SYMBOL(cancel_rearming_delayed_wo /** * cancel_rearming_delayed_work - reliably kill off a delayed keventd work whose handler rearms the delayed work. * @dwork: the delayed work struct + * + * WARNING: use only with handlers, which rearm unconditionally with delay > 0 */ void cancel_rearming_delayed_work(struct delayed_work *dwork) { - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |