lkml.org 
[lkml]   [2007]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] sas_scsi_host: Convert to use the kthread API
    Date
    From: Eric W. Biederman <ebiederm@xmission.com> - unquoted

    This patch modifies the sas scsi host thread startup
    to use kthread_run not kernel_thread and deamonize.
    kthread_run is slightly simpler and more maintainable.

    Cc: Darrick J. Wong <djwong@us.ibm.com>
    Cc: James Bottomley <James.Bottomley@SteelEye.com>
    Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
    ---
    drivers/scsi/libsas/sas_scsi_host.c | 11 ++++++-----
    1 files changed, 6 insertions(+), 5 deletions(-)

    diff --git a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c
    index 46ba3a7..7a38ac5 100644
    --- a/drivers/scsi/libsas/sas_scsi_host.c
    +++ b/drivers/scsi/libsas/sas_scsi_host.c
    @@ -40,6 +40,7 @@
    #include <linux/blkdev.h>
    #include <linux/scatterlist.h>
    #include <linux/freezer.h>
    +#include <linux/kthread.h>

    /* ---------- SCSI Host glue ---------- */

    @@ -870,7 +871,6 @@ static int sas_queue_thread(void *_sas_ha)
    struct sas_ha_struct *sas_ha = _sas_ha;
    struct scsi_core *core = &sas_ha->core;

    - daemonize("sas_queue_%d", core->shost->host_no);
    current->flags |= PF_NOFREEZE;

    complete(&queue_th_comp);
    @@ -891,19 +891,20 @@ static int sas_queue_thread(void *_sas_ha)

    int sas_init_queue(struct sas_ha_struct *sas_ha)
    {
    - int res;
    struct scsi_core *core = &sas_ha->core;
    + struct task_struct *task;

    spin_lock_init(&core->task_queue_lock);
    core->task_queue_size = 0;
    INIT_LIST_HEAD(&core->task_queue);
    init_MUTEX_LOCKED(&core->queue_thread_sema);

    - res = kernel_thread(sas_queue_thread, sas_ha, 0);
    - if (res >= 0)
    + task = kthread_run(sas_queue_thread, sas_ha,
    + "sas_queue_%d", core->shost->host_no);
    + if (!IS_ERR(task))
    wait_for_completion(&queue_th_comp);

    - return res < 0 ? res : 0;
    + return IS_ERR(task) ? PTR_ERR(task) : 0;
    }

    void sas_shutdown_queue(struct sas_ha_struct *sas_ha)
    --
    1.5.0.g53756
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-19 09:07    [W:0.022 / U:61.816 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site