lkml.org 
[lkml]   [2007]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [RFC PATCH 1/2] Fix PF_NOFREEZE and freezeable race
    Date
    Hi,

    On Thursday, 19 April 2007 14:02, Gautham R Shenoy wrote:
    > This patch fixes the race pointed out by Oleg Nesterov.
    >
    > * Freezer marks a thread as freezeable.
    > * The thread now marks itself PF_NOFREEZE causing it to
    > freeze on calling try_to_freeze(). Thus the task is frozen, even though
    > it doesn't want to.
    > * Subsequent thaw_processes() will also fail to thaw the task since it is
    > marked PF_NOFREEZE.
    >
    > Avoid this problem by checking the current task's PF_NOFREEZE status in the
    > refrigerator before marking current as frozen.
    >
    > Signed-off-by: Gautham R Shenoy <ego@in.ibm.com>

    Looks good, although I'm not sure if we don't need to call recalc_sigpending()
    for tasks that turn out to be PF_NOFREEZE.

    Greetings,
    Rafael
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-20 00:31    [W:0.023 / U:0.072 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site