lkml.org 
[lkml]   [2007]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 09/12] mm: count unstable pages per BDI
    From
    Date
    > Index: linux-2.6/fs/buffer.c
    > ===================================================================
    > --- linux-2.6.orig/fs/buffer.c 2007-04-19 19:59:26.000000000 +0200
    > +++ linux-2.6/fs/buffer.c 2007-04-19 20:35:39.000000000 +0200
    > @@ -733,7 +733,7 @@ int __set_page_dirty_buffers(struct page
    > if (page->mapping) { /* Race with truncate? */
    > if (mapping_cap_account_dirty(mapping)) {
    > __inc_zone_page_state(page, NR_FILE_DIRTY);
    > - __inc_bdi_stat(mapping->backing_dev_info, BDI_DIRTY);
    > + __inc_bdi_stat(mapping->backing_dev_info, BDI_RECLAIM);

    This name suggests it's _under_ reclaim, which is not true. You might
    rather want to call it BDI_RECLAIMABLE, or something similar in
    meaning.

    Miklos
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-19 21:25    [W:0.018 / U:96.668 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site