lkml.org 
[lkml]   [2007]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 10/11] Char: cyclades, clear interrupts before releasing
    From
    Date
    cyclades, clear interrupts before releasing

    Without this patch, the driver sometimes causes "IRQXX: Nobody cares". Fix
    it by turning off irqs when releasing.

    Signed-off-by: Jiri Slaby <jirislaby@gmail.com>

    ---
    commit 0156510dee9d326af2ec52cf8b1a388ce9a839e9
    tree 29d863d5eca58913c306bc8cd9a6b3a5dcef01fe
    parent ad4f792b92f8e6350a62b61442bb6812969bfd73
    author Jiri Slaby <jirislaby@gmail.com> Thu, 05 Apr 2007 18:26:08 +0200
    committer Jiri Slaby <jirislaby@gmail.com> Tue, 10 Apr 2007 10:48:09 +0200

    drivers/char/cyclades.c | 13 +++++++++++++
    1 files changed, 13 insertions(+), 0 deletions(-)

    diff --git a/drivers/char/cyclades.c b/drivers/char/cyclades.c
    index 0c2c120..5a9e7d6 100644
    --- a/drivers/char/cyclades.c
    +++ b/drivers/char/cyclades.c
    @@ -5341,6 +5341,17 @@ static void __devexit cy_pci_release(struct pci_dev *pdev)
    struct cyclades_card *cinfo = pci_get_drvdata(pdev);
    unsigned int i;

    + /* non-Z with old PLX */
    + if (cinfo->num_chips != -1 && (readb(cinfo->base_addr + CyPLX_VER) &
    + 0x0f) == PLX_9050)
    + cy_writeb(cinfo->ctl_addr + 0x4c, 0);
    + else
    +#ifndef CONFIG_CYZ_INTR
    + if (cinfo->num_chips != -1)
    +#endif
    + cy_writew(cinfo->ctl_addr + 0x68,
    + readw(cinfo->ctl_addr + 0x68) & ~0x0900);
    +
    pci_iounmap(pdev, cinfo->base_addr);
    if (cinfo->ctl_addr)
    pci_iounmap(pdev, cinfo->ctl_addr);
    @@ -5560,6 +5571,8 @@ static void __exit cy_cleanup_module(void)
    cy_pci_release(cy_card[i].pdev);
    continue;
    }
    + /* clear interrupt */
    + cy_writeb(cy_card[i].base_addr + Cy_ClrIntr, 0);
    iounmap(cy_card[i].base_addr);
    if (cy_card[i].ctl_addr)
    iounmap(cy_card[i].ctl_addr);
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-04-18 12:11    [W:0.020 / U:4.260 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site