lkml.org 
[lkml]   [2007]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [nameidata 1/2] Don't pass NULL nameidata to vfs_create
    Date
    On Monday 16 April 2007 18:21, Christoph Hellwig wrote:
    > But anyway, creating fake nameidata structures is not really helpful.
    > If there is a nameidata passed people expect it to be complete, and
    > if you pass them to an LSM people will e.g. try to look into lookup
    > intents.

    I don't actually agree with that: when nfsd creates a file, it still is a file
    create no matter where it originates from, and so it does make sense to
    provide the appropriate intent information too. Struct nameidata contains
    other crap only needed during an actual lookup too --- that's a mess, and the
    nameidata2 patch shows one possibility how to deal with it. (It's the
    cleanest approach I could think of right now without cluttering the vfs code
    with insane amounts of dereferences.)

    Thanks,
    Andreas
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-16 18:43    [W:4.117 / U:0.308 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site