lkml.org 
[lkml]   [2007]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [nameidata 1/2] Don't pass NULL nameidata to vfs_create
    On Mon, Apr 16, 2007 at 06:11:30PM +0200, Andreas Gruenbacher wrote:
    > +static inline int
    > +nfsd_do_create(struct inode *dir, struct dentry *child, struct vfsmount *mnt,
    > + int mode)
    > +{
    > + struct nameidata nd = {
    > + .dentry = child,
    > + .mnt = mnt,
    > + };
    > +
    > + return vfs_create(dir, child, mode, &nd);
    > +}
    > +

    Wouldn't it normally result in fewer instructions (on most architectures
    ... maybe not x86) to keep the same argument order as vfs_create? ie:

    static inline int nfsd_do_create(struct inode *dir, struct dentry *child,
    int mode, struct vfsmount *mnt)

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-16 18:29    [W:0.019 / U:62.384 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site