lkml.org 
[lkml]   [2007]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Don't attach callback to a going-away netlink socket
    Pavel Emelianov wrote:
    > Patrick McHardy wrote:
    >
    >>>There is a race between netlink_dump_start() and netlink_release()
    >>>that can lead to the situation when a netlink socket with non-zero
    >>>callback is freed.
    >>
    >>
    >>Can you describe the race in more detail please?
    >>
    >
    > Here it is:
    >
    > [...]
    > The proposal it to make sock_orphan before detaching the callback
    > in netlink_release() and to check for the sock to be SOCK_DEAD in
    > netlink_dump_start() before setting a new callback.


    Thanks, good catch. Your patch also looks good.

    Acked-by: Patrick McHardy <kaber@trash.net>

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-16 14:57    [W:0.020 / U:29.404 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site