![]() | |||||||||||
Messages in this thread |
> > > > +#ifndef CONFIG_ALPHA_GENERIC > > > +EXPORT_SYMBOL(tsunami_ioportmap); > > > +EXPORT_SYMBOL(tsunami_ioremap); > > > +#endif > > > > It looks strange that the function is always defined but conditionally exported. > > Also usual style is to place EXPORT right after closing brace of function - > > (with no empty lines in-between). > > In a generic kernel the IO functions are never addressed directly, > only via machine vector, so there is no point in exporting them. > What about something like EXPORT_SYMBOL_NONGENERIC() macro? As I wrote it looked strange. Unconditionally exporting them should not harm and then we are one pair of ifdef/endif shorter? Nitty gritty detail so do what you think match best. Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||
| Last update: 2007-04-15 14:33 [from the cache] ©2003-2008 | |||||||||||