[lkml]   [2007]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 17/28] x86: cleanup arch/i386/kernel/cpu/mcheck/p4.c
    No, just no.  You do not use goto to skip a code block.  You do not
    return an obvious variable from a singly-inlined function and give
    the function a return value. You don't put unexplained comments
    about kmalloc in code which doesn't do dynamic allocation. And
    you don't leave stray warnings around for no good reason.

    Also, when possible, it is better to use block scoped variables
    because gcc can sometime generate better code.

    From: Zachary Amsden <>
    Signed-off-by: Zachary Amsden <>

    arch/i386/kernel/cpu/mcheck/p4.c | 16 ++++------------
    1 file changed, 4 insertions(+), 12 deletions(-)

    --- a/arch/i386/kernel/cpu/mcheck/p4.c
    +++ b/arch/i386/kernel/cpu/mcheck/p4.c
    @@ -124,12 +124,9 @@ static void intel_init_thermal(struct cp

    /* P4/Xeon Extended MCE MSR retrieval, return 0 if unsupported */
    -static inline int intel_get_extended_msrs(struct intel_mce_extended_msrs *r)
    +static inline void intel_get_extended_msrs(struct intel_mce_extended_msrs *r)
    u32 h;
    - if (mce_num_extended_msrs == 0)
    - goto done;

    rdmsr (MSR_IA32_MCG_EAX, r->eax, h);
    rdmsr (MSR_IA32_MCG_EBX, r->ebx, h);
    @@ -141,12 +138,6 @@ static inline int intel_get_extended_msr
    rdmsr (MSR_IA32_MCG_ESP, r->esp, h);
    rdmsr (MSR_IA32_MCG_EFLAGS, r->eflags, h);
    rdmsr (MSR_IA32_MCG_EIP, r->eip, h);
    - /* can we rely on kmalloc to do a dynamic
    - * allocation for the reserved registers?
    - */
    - return mce_num_extended_msrs;

    static fastcall void intel_machine_check(struct pt_regs * regs, long error_code)
    @@ -155,7 +146,6 @@ static fastcall void intel_machine_check
    u32 alow, ahigh, high, low;
    u32 mcgstl, mcgsth;
    int i;
    - struct intel_mce_extended_msrs dbg;

    rdmsr (MSR_IA32_MCG_STATUS, mcgstl, mcgsth);
    if (mcgstl & (1<<0)) /* Recoverable ? */
    @@ -164,7 +154,9 @@ static fastcall void intel_machine_check
    printk (KERN_EMERG "CPU %d: Machine Check Exception: %08x%08x\n",
    smp_processor_id(), mcgsth, mcgstl);

    - if (intel_get_extended_msrs(&dbg)) {
    + if (mce_num_extended_msrs > 0) {
    + struct intel_mce_extended_msrs dbg;
    + intel_get_extended_msrs(&dbg);
    printk (KERN_DEBUG "CPU %d: EIP: %08x EFLAGS: %08x\n",
    smp_processor_id(), dbg.eip, dbg.eflags);
    printk (KERN_DEBUG "\teax: %08x ebx: %08x ecx: %08x edx: %08x\n",

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2007-04-14 23:27    [W:0.023 / U:2.912 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site