lkml.org 
[lkml]   [2007]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 24/28] paravirt: drop unused ptep_get_and_clear
    In shadow mode hypervisors, ptep_get_and_clear achieves the desired
    purpose of keeping the shadows in sync by issuing a native_get_and_clear,
    followed by a call to pte_update, which indicates the PTE has been
    modified.

    Direct mode hypervisors (Xen) have no need for this anyway, and will trap
    the update using writable pagetables.

    This means no hypervisor makes use of ptep_get_and_clear; there is no
    reason to have it in the paravirt-ops structure. Change confusing
    terminology about raw vs. native functions into consistent use of
    native_pte_xxx for operations which do not invoke paravirt-ops.

    Signed-off-by: Zachary Amsden <zach@vmware.com>

    ---
    arch/i386/kernel/paravirt.c | 2 --
    include/asm-i386/paravirt.h | 13 +------------
    include/asm-i386/pgtable.h | 4 +---
    3 files changed, 2 insertions(+), 17 deletions(-)

    ===================================================================
    --- a/arch/i386/kernel/paravirt.c
    +++ b/arch/i386/kernel/paravirt.c
    @@ -315,8 +315,6 @@ struct paravirt_ops paravirt_ops = {
    .pte_update = paravirt_nop,
    .pte_update_defer = paravirt_nop,

    - .ptep_get_and_clear = native_ptep_get_and_clear,
    -
    #ifdef CONFIG_HIGHPTE
    .kmap_atomic_pte = kmap_atomic,
    #endif
    ===================================================================
    --- a/include/asm-i386/paravirt.h
    +++ b/include/asm-i386/paravirt.h
    @@ -187,8 +187,6 @@ struct paravirt_ops
    void (*pte_update)(struct mm_struct *mm, unsigned long addr, pte_t *ptep);
    void (*pte_update_defer)(struct mm_struct *mm,
    unsigned long addr, pte_t *ptep);
    -
    - pte_t (*ptep_get_and_clear)(pte_t *ptep);

    #ifdef CONFIG_HIGHPTE
    void *(*kmap_atomic_pte)(struct page *page, enum km_type type);
    @@ -859,12 +857,8 @@ static inline void pmd_clear(pmd_t *pmdp
    PVOP_VCALL1(pmd_clear, pmdp);
    }

    -static inline pte_t raw_ptep_get_and_clear(pte_t *p)
    -{
    - unsigned long long val = PVOP_CALL1(unsigned long long, ptep_get_and_clear, p);
    - return (pte_t) { val, val >> 32 };
    -}
    #else /* !CONFIG_X86_PAE */
    +
    static inline pte_t __pte(unsigned long val)
    {
    return (pte_t) { PVOP_CALL1(unsigned long, make_pte, val) };
    @@ -899,11 +893,6 @@ static inline void set_pmd(pmd_t *pmdp,
    static inline void set_pmd(pmd_t *pmdp, pmd_t pmdval)
    {
    PVOP_VCALL2(set_pmd, pmdp, pmdval.pud.pgd.pgd);
    -}
    -
    -static inline pte_t raw_ptep_get_and_clear(pte_t *p)
    -{
    - return (pte_t) { PVOP_CALL1(unsigned long, ptep_get_and_clear, p) };
    }
    #endif /* CONFIG_X86_PAE */

    ===================================================================
    --- a/include/asm-i386/pgtable.h
    +++ b/include/asm-i386/pgtable.h
    @@ -265,8 +265,6 @@ static inline pte_t pte_mkhuge(pte_t pte
    */
    #define pte_update(mm, addr, ptep) do { } while (0)
    #define pte_update_defer(mm, addr, ptep) do { } while (0)
    -
    -#define raw_ptep_get_and_clear(xp) native_ptep_get_and_clear(xp)
    #endif

    /*
    @@ -340,7 +338,7 @@ do { \
    #define __HAVE_ARCH_PTEP_GET_AND_CLEAR
    static inline pte_t ptep_get_and_clear(struct mm_struct *mm, unsigned long addr, pte_t *ptep)
    {
    - pte_t pte = raw_ptep_get_and_clear(ptep);
    + pte_t pte = native_ptep_get_and_clear(ptep);
    pte_update(mm, addr, ptep);
    return pte;
    }
    --

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-14 23:25    [W:0.024 / U:92.684 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site