lkml.org 
[lkml]   [2007]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateThu, 12 Apr 2007 09:38:15 -0700 (PDT)
FromChristoph Lameter <>
SubjectRe: SLUB: kmem_cache_destroy doesn't
On Thu, 12 Apr 2007, Neil Brown wrote:

> And
>
> # cat /sys/slab/raid5-md1/aliases
> -1
>
> is a bit suspicious.

Yuck!

> void kmem_cache_destroy(struct kmem_cache *s)
> {
> down_write(&slub_lock);
> if (s->refcount)
> s->refcount--;
> else {
> list_del(&s->list);
> WARN_ON(kmem_cache_close(s));
> sysfs_slab_remove(s);
> kfree(s);
> }
> up_write(&slub_lock);
> }
>
> looks a bit odd.
> I would have thought the test should be:
>
> if (s->refcount > 1)

Correct. Does the change fix it?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-04-12 18:41    [from the cache]
©2003-2010