lkml.org 
[lkml]   [2007]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/7] [RFC] Battery monitoring class
    On Thu, Apr 12, 2007 at 03:25:03AM +0400, Anton Vorontsov wrote:
    > Here is battery monitor class. According to first copyright string, we're
    > maintaining it since 2003. I've took few days and cleaned it up to be
    > more suitable for mainline inclusion.
    >
    > It differs from battery class at git://git.infradead.org/battery-2.6.git:

    Why fork from David's work? Does he not like these changes for some
    reason?

    > +static int battery_create_attrs(struct battery *bat)
    > +{
    > + int rc;
    > +
    > + #define create_bat_attr_conditional(name) \
    > + if(bat->get_##name) { \
    > + rc = device_create_file(bat->dev, &dev_attr_##name); \
    > + if (rc) goto name##_failed; \
    > + }
    > +
    > + create_bat_attr_conditional(status);
    > + create_bat_attr_conditional(min_voltage);
    > + create_bat_attr_conditional(min_current);
    > + create_bat_attr_conditional(min_capacity);
    > + create_bat_attr_conditional(max_voltage);
    > + create_bat_attr_conditional(max_current);
    > + create_bat_attr_conditional(max_capacity);
    > + create_bat_attr_conditional(temp);
    > + create_bat_attr_conditional(voltage);
    > + create_bat_attr_conditional(current);
    > + create_bat_attr_conditional(capacity);

    Use an attribute group please. It's much simpler and will be created at
    the proper time so your userspace tools don't have to sit and spin in
    order to properly wait for them to show up.

    Ok, yes, you want a conditional type of attribute group, like the
    new firewire code does. I have no problem adding that if you like.

    thanks,

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-12 05:55    [W:0.031 / U:30.568 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site