lkml.org 
[lkml]   [2007]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 12/17] partition: remove redundant read_mapping_page error checks
    Remove unneeded PageError checking in read_dev_sector(), and clean up the
    code a bit.

    Can anyone point out why it's OK to use page_address() here on a page which
    has not been kmapped? If it's not OK, then a good number of callers need to
    be fixed.

    Signed-off-by: Nate Diller <nate.diller@gmail.com>

    ---

    diff -urpN -X dontdiff linux-2.6.21-rc6-mm1/fs/partitions/check.c linux-2.6.21-rc6-mm1-test/fs/partitions/check.c
    --- linux-2.6.21-rc6-mm1/fs/partitions/check.c 2007-04-09 17:24:03.000000000 -0700
    +++ linux-2.6.21-rc6-mm1-test/fs/partitions/check.c 2007-04-10 21:59:01.000000000 -0700
    @@ -568,16 +568,12 @@ unsigned char *read_dev_sector(struct bl

    page = read_mapping_page(mapping, (pgoff_t)(n >> (PAGE_CACHE_SHIFT-9)),
    NULL);
    - if (!IS_ERR(page)) {
    - if (PageError(page))
    - goto fail;
    - p->v = page;
    - return (unsigned char *)page_address(page) + ((n & ((1 << (PAGE_CACHE_SHIFT - 9)) - 1)) << 9);
    -fail:
    - page_cache_release(page);
    + if (IS_ERR(page)) {
    + p->v = NULL;
    + return NULL;
    }
    - p->v = NULL;
    - return NULL;
    + p->v = page;
    + return (unsigned char *)page_address(page) + ((n & ((1 << (PAGE_CACHE_SHIFT - 9)) - 1)) << 9);
    }

    EXPORT_SYMBOL(read_dev_sector);
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-04-12 04:57    [W:2.077 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site