lkml.org 
[lkml]   [2007]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [-mm3 patch]Warning fix: check the return value of kobject_add etc.
On Sun, Apr 01, 2007 at 02:20:46PM +0800, Cong WANG wrote:
> 2007/4/1, Andrew Morton <akpm@linux-foundation.org>:
> >
> >Also, please always prepare patches in `patch -p1' form, as per
> >http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt, thanks.
> >
> >
>
> Sorry. I am confused with this. Does that mean I should make patches
> _upon_ the root kernel source directory or first make a copy of the
> original source code and then diff against the two dirs? But I was
> told that "patches should be based _in_ the root kernel source
> directory" and when only one file was modified just to diff it with
> the original single file. (See Documentation/SubmittingPatches.)
>
> Can you help out? And should I remake this patch? Thanks again!

quilt(http://savannah.nongnu.org/projects/quilt) is your friend.

cd /usr/src/linux
quilt new my-fix.patch
quilt edit mm/readahead.c
quilt refresh --diffstat
quilt diff
...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-04-11 08:29    [W:0.055 / U:2.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site