lkml.org 
[lkml]   [2007]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] console UTF-8 fixes
    Egmont Koblinger wrote:
    > +static int is_zero_width(long ucs)
    > +{
    > + static const struct interval zero_width[] = {
    /* lots */
    > + };

    I'm still unhappy about these large search tables in the kernel, not
    because they take a huge amount of space (it's not that much), but
    because they're invariably going to be stale, as they're Unicode-version
    dependent.

    At least please put them in a separate .c file and include a script to
    generate them clean from UnicodeData.txt.

    Besides, would it not make more sense to have a single table with the
    width information, if you insist on having one, instead of multiple ones?

    -hpa
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-11 20:39    [W:3.036 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site