lkml.org 
[lkml]   [2007]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] kthread: Don't depend on work queues
    On 04/11, Gautham R Shenoy wrote:
    >
    > On Wed, Apr 11, 2007 at 12:13:34PM +0200, Rafael J. Wysocki wrote:
    > >
    > > It should be calling try_to_freeze() somewhere anyway. We may need to freeze
    > > all tasks in some cases.
    >
    > How about
    > for (;;) {
    > try_to_freeze();
    >
    > ?

    Why?

    > This change allows us to make all the worker threads freezeable by default.
    > >From cpu-hotplug perspective, helper_wq was the only singlethreaded
    > non-freezeable workqueue.

    I think Eric's patch is what you need. We should _not_ freeze kthreadd(), we
    need kthread_create() after freezing. Now it doesn't depend on workqueues, we
    can freeze them all, single-thread or not.

    I like this patch.

    Oleg.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-11 13:51    [W:0.024 / U:0.128 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site