Messages in this thread | | | Date | Wed, 11 Apr 2007 15:48:05 +0400 | From | Oleg Nesterov <> | Subject | Re: [PATCH] kthread: Don't depend on work queues |
| |
On 04/11, Gautham R Shenoy wrote: > > On Wed, Apr 11, 2007 at 12:13:34PM +0200, Rafael J. Wysocki wrote: > > > > It should be calling try_to_freeze() somewhere anyway. We may need to freeze > > all tasks in some cases. > > How about > for (;;) { > try_to_freeze(); > > ?
Why?
> This change allows us to make all the worker threads freezeable by default. > >From cpu-hotplug perspective, helper_wq was the only singlethreaded > non-freezeable workqueue.
I think Eric's patch is what you need. We should _not_ freeze kthreadd(), we need kthread_create() after freezing. Now it doesn't depend on workqueues, we can freeze them all, single-thread or not.
I like this patch.
Oleg.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |