lkml.org 
[lkml]   [2007]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: link error : 2.6.21-rc6-mm1 for s390
    From
    From: Andrew Morton <akpm@linux-foundation.org>
    Date: Tue, 10 Apr 2007 18:47:38 -0700

    > On Tue, 10 Apr 2007 18:36:29 -0700 (PDT)
    > David Miller <davem@davemloft.net> wrote:
    >
    > > From: Andrew Morton <akpm@linux-foundation.org>
    > > Date: Tue, 10 Apr 2007 18:29:37 -0700
    > >
    > > > git-net.patch implements generic lib/div64.c, but s390 also has a
    > > > private one. Presumably the appropriate fix is to remove s390's
    > > > private implementation within davem's tree.
    > >
    > > The s390 version seems to be optimized in assembler for that
    > > processor, therefore we should probably instead elide the
    > > generic version on s390.
    >
    > We're sure that it has the same API?

    Yes, I read over it, I'm pretty sure it does.

    > attribute(weak) would give a nicer result?

    I'm not so sure.

    > We'd also need to remove s390's EXPORT_SYMBOL(__div64_32), so s390 ends up
    > using lib/div64.c's EXPORT_SYMBOL().

    It shouldn't matter if we use s390's or the generic version's....

    Oh, I see, s390 uses lib-y for it's div64.o object, that's a bug.
    I'll fix that up, thanks Andrew.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-11 04:09    [W:0.023 / U:1.424 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site