Messages in this thread | | | Date | Tue, 10 Apr 2007 19:54:54 +0400 | From | Evgeniy Polyakov <> | Subject | Re: [PATCH 2/2] NET: Multiqueue network device support implementation. |
| |
On Tue, Apr 10, 2007 at 08:41:49AM -0700, Waskiewicz Jr, Peter P (peter.p.waskiewicz.jr@intel.com) wrote: > > On Mon, Apr 09, 2007 at 02:28:41PM -0700, Peter P Waskiewicz > > Jr (peter.p.waskiewicz.jr@intel.com) wrote: > > > + alloc_size = (sizeof(struct net_device_subqueue) * queue_count); > > > + > > > + p = kzalloc(alloc_size, GFP_KERNEL); > > > + if (!p) { > > > + printk(KERN_ERR "alloc_netdev: Unable to > > allocate queues.\n"); > > > + return NULL; > > > > I think you either do not want to print it, or want > > additional details about device... > > Ok. This is essentially the same output printed if the netdev itself > cannot be allocated. Should I update both strings to have more > device-specific information?
I wonder, if it is ever possible with gfp_kernel...
I think different patch would be ok.
-- Evgeniy Polyakov - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |