Messages in this thread Patch in this message | | | Date | Sun, 1 Apr 2007 15:32:34 +0800 | From | "Cong WANG" <> | Subject | [-mm3 PATCH] (Retry) Check the return value of kobject_add and etc. |
| |
Since kobject_add, sysfs_create_link and sysfs_create_file are marked as '__must_check', we must always check their return values.
Signed-off-by: Cong WANG <xiyou.wangcong@gmail.com>
--- --- linux-2.6.21-rc5-mm3/fs/partitions/check.c.orig 2007-03-30 21:35:45.000000000 +0800 +++ linux-2.6.21-rc5-mm3/fs/partitions/check.c 2007-03-30 21:49:53.000000000 +0800 @@ -385,10 +385,16 @@ void add_partition(struct gendisk *disk, p->kobj.parent = &disk->kobj; p->kobj.ktype = &ktype_part; kobject_init(&p->kobj); - kobject_add(&p->kobj); + if (kobject_add(&p->kobj)) { + kfree(p); + return; + } if (!disk->part_uevent_suppress) kobject_uevent(&p->kobj, KOBJ_ADD); - sysfs_create_link(&p->kobj, &block_subsys.kset.kobj, "subsystem"); + if (sysfs_create_link(&p->kobj, &block_subsys.kset.kobj, "subsystem")) { + kfree(p); + return; + } if (flags & ADDPART_FLAG_WHOLEDISK) { static struct attribute addpartattr = { .name = "whole_disk", @@ -396,7 +402,10 @@ void add_partition(struct gendisk *disk, .owner = THIS_MODULE, };
- sysfs_create_file(&p->kobj, &addpartattr); + if (sysfs_create_file(&p->kobj, &addpartattr)) { + kfree(p); + return; + } } partition_sysfs_add_subdir(p); disk->part[part-1] = p; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |