Messages in this thread | | | Date | Sun, 1 Apr 2007 14:46:50 +0800 | From | "Cong WANG" <> | Subject | Re: [-mm3 patch]Warning fix: check the return value of kobject_add etc. |
| |
2007/4/1, Andrew Morton <akpm@linux-foundation.org>: > On Sun, 1 Apr 2007 14:20:46 +0800 "Cong WANG" <xiyou.wangcong@gmail.com> wrote: > > > > > > > > > Also, please always prepare patches in `patch -p1' form, as per > > > http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt, thanks. > > > > > > > > > > Sorry. I am confused with this. Does that mean I should make patches > > _upon_ the root kernel source directory or first make a copy of the > > original source code and then diff against the two dirs? But I was > > told that "patches should be based _in_ the root kernel source > > directory" and when only one file was modified just to diff it with > > the original single file. (See Documentation/SubmittingPatches.) > > The headers should look like: > > --- a/arch/cris/kernel/crisksyms.c > +++ a/arch/cris/kernel/crisksyms.c > > I don't know how people do that. One obvious way is to do > > cd /usr/src > diff -u linux-orig/arch/cris/kernel/crisksyms.c linux-new/arch/cris/kernel/crisksyms.c > > other people probably alter the diff headers.
Oh, thanks. I know.
> > > And should I remake this patch? > > Sure, but please change it to perform correct error handling first. And > test that error handling, if you can. That will involve adding artificial > errors. >
I will remake it soon and send it again.
In fact, I have just tested it roughly. And I don't how to produce artificial errors. Sorry, I hope someone can help me to test it carefully. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |