lkml.org 
[lkml]   [2007]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Use more gcc extensions in the Linux headers

On Mar 10 2007 09:57, Rusty Russell wrote:
>On Fri, 2007-03-09 at 16:56 +1100, Rusty Russell wrote:
>> __builtin_types_compatible_p() has been around since gcc 2.95, and we
>> don't use it anywhere. This patch quietly fixes that.
>
>OK, many people complained that it needed a comment. Good point!
>==
>Add comment to ARRAY_SIZE macro.
>
>Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>
>diff -r 933e410f204f include/linux/kernel.h
>--- a/include/linux/kernel.h Sat Mar 10 09:55:31 2007 +1100
>+++ b/include/linux/kernel.h Sat Mar 10 09:55:53 2007 +1100
>@@ -35,6 +35,7 @@ extern const char linux_proc_banner[];
> #define ALIGN(x,a) __ALIGN_MASK(x,(typeof(x))(a)-1)
> #define __ALIGN_MASK(x,mask) (((x)+(mask))&~(mask))
>
>+/* GCC is awesome. */
> #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) \
> + sizeof(typeof(int[1 - 2*!!__builtin_types_compatible_p(typeof(arr), \
> typeof(&arr[0]))]))*0)

Getting back at the macro, how would you like to have it merged?



Jan
--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-03-10 02:09    [W:0.172 / U:0.428 seconds]
©2003-2014 Jasper Spaans. Advertise on this site