Messages in this thread | | | Date | Fri, 9 Mar 2007 11:11:13 -0500 | From | Benjamin LaHaise <> | Subject | Re: [PATCH 2/7] revoke: add f_light flag for struct file |
| |
On Fri, Mar 09, 2007 at 12:13:35PM +0100, Eric Dumazet wrote: > Then just drop the fget_light() 'optimisation' and always take a reference > (atomic on f_count) regardless of single-thread or not. Instead of dirtying > f_light, just do the straightforward thing and be with it. > > (that is : fget_light() = fget() = no more keeping fput_needed everywhere, and > convoluted things in some dark sides of the kernel.
And it makes things rather slower for a lot of single threaded applications on modern systems. Yes, fget_light can be done much more cleanly, but please don't go around ripping out optimizations just because.
-ben -- "Time is of no importance, Mr. President, only life is important." Don't Email: <zyntrop@kvack.org>. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |