lkml.org 
[lkml]   [2007]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectFwd: Re: 2.6.21-rc suspend regression: sysfs deadlock
Date
To let you hear the verdict.

Regards
Oliver

---------- Weitergeleitete Nachricht ----------

Subject: Re: 2.6.21-rc suspend regression: sysfs deadlock
Date: Mittwoch, 7. März 2007 19:02
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Oliver Neukum <oliver@neukum.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>, Hugh Dickins <hugh@veritas.com>, Oliver Neukum <oliver@neukum.name>, Maneesh Soni <maneesh@in.ibm.com>, Greg Kroah-Hartman <gregkh@suse.de>, Adrian Bunk <bunk@stusta.de>, linux-kernel@vger.kernel.org


On Wed, 7 Mar 2007, Oliver Neukum wrote:
>
> The problem also exists with unplugging devices. Drivers get no feedback
> to tell them when it is safe to free the data structures associated with
> an attribute.

So you just pointed to *another* data structure that apparently violates
the "you MUST use refcounting" rule.

What is it with you people? It's really simple. Data structures must be
refcounted if you can reach them two different ways.

If you don't use refcounting, then you'd better make sure that the data
can be reached only one way (for example, by *not* exposing it for sysfs).

It really *is* that simple. Read the CodingStyle rules.

Linus


-------------------------------------------------------
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-03-09 01:45    [W:0.025 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site