lkml.org 
[lkml]   [2007]   [Mar]   [7]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateWed, 7 Mar 2007 22:01:12 +0530
FromSrivatsa Vaddagiri <>
SubjectRe: [ckrm-tech] [PATCH 2/7] containers (V7): Cpusets hooked into containers
On Wed, Mar 07, 2007 at 08:01:32AM -0800, Paul Menage wrote:
> > > @@ -913,12 +537,14 @@ static int update_nodemask(struct cpuset
> > >       int migrate;
> > >       int fudge;
> > >       int retval;
> > > +     struct container *cont;
> >
> > This seems to be redundant?
> 
> It gets used in the lower loop checking for processes whose memory
> policies we should be rebinding.

It makes sense in the first cpuset patch
(cpusets_using_containers.patch), but should be removed in the second
cpuset patch (multiuser_container.patch). In the 2nd patch, we use this
comparison:

	if (task_cs(p) != cs)
		continue;
cont variable introduced in the 1st patch essentially becomes unused
after 2nd patch.

-- 
Regards,
vatsa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-03-07 17:27    [from the cache]
©2003-2008