lkml.org 
[lkml]   [2007]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [ckrm-tech] [PATCH 3/3][RFC] Containers: Pagecache controller reclaim
From
Date
On Tue, 2007-03-06 at 16:43 +0530, Vaidyanathan Srinivasan wrote:
>
> Please let me know if so see any problem running the patch. The
> patches are against 2.6.20 only since dependent patches are at that level.

My problem - a bad copy of the patch. It patches o.k.
However, it fails to compile vmscan. This looks a bit dodgy;

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

@@ -1470,11 +1494,13 @@ unsigned long shrink_all_memory(unsigned
int pass;
struct reclaim_state reclaim_state;
struct scan_control sc = {
- .gfp_mask = GFP_KERNEL,
+ .gfp_mask = GFdefined(CONFIG_CONTAINER_PAGECACHE_ACCT)
+P_KERNEL,

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

I deleted what looks like an over-enthusiastic "copy-and-paste", and it
compiled o.k.
Testing continues.

Shane ...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-03-07 10:11    [W:0.064 / U:0.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site