Messages in this thread | | | Date | Mon, 5 Mar 2007 18:34:10 -0800 (PST) | From | Davide Libenzi <> | Subject | Re: [patch v2] epoll use a single inode ... |
| |
On Mon, 5 Mar 2007, H. Peter Anvin wrote:
> Linus Torvalds wrote: > > > > Since this is not actually *used* for anything but showing the fd's in > > /proc/<pid>/fd/ etc, no. In fact, an integer will wrap a *lot* less than a > > kernel data structure will be re-used, so even with the simple "wraps every > > 4G uses", you're still better off. > > > > ... and if that worries you, use a 64-bit counter. They're cheap (compared to > an sprintf), and even if they advance once a nanosecond they won't wrap around > for over 584 years.
Right now is using:
this.len = sprintf(name, "[%u.%d]", current->pid, fd);
That should be unique and not have the wraparound problem. Ack?
- Davide
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |