lkml.org 
[lkml]   [2007]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[2.6.21 patch] unconditionally enable SYSFS_DEPRECATED
    On Mon, Mar 05, 2007 at 10:58:13AM -0800, Greg KH wrote:
    >
    > Ok, how about the following patch. Is it acceptable to everyone?
    >
    > thanks,
    >
    > greg k-h
    >
    > ---
    > init/Kconfig | 13 +++++++++++--
    > 1 file changed, 11 insertions(+), 2 deletions(-)
    >
    > --- gregkh-2.6.orig/init/Kconfig
    > +++ gregkh-2.6/init/Kconfig
    > @@ -290,8 +290,17 @@ config SYSFS_DEPRECATED
    > that belong to a class, back into the /sys/class heirachy, in
    > order to support older versions of udev.
    >
    > - If you are using a distro that was released in 2006 or later,
    > - it should be safe to say N here.
    > + If you are using an OpenSuSE, Gentoo, Ubuntu, or Fedora
    > + release from 2007 or later, it should be safe to say N here.
    > +
    > + If you are using Debian or other distros that are slow to
    > + update HAL, please say Y here.
    >...

    The sane solution seems to be to enable SYSFS_DEPRECATED unconditionally
    for all users, and schedule it's removal for mid-2008 (or later).

    12 months after the first _release_ of a HAL that can live without seems
    to be the first time when we can consider getting rid of it, since all
    distributions with at least one release a year should ship it by then.

    Currently, SYSFS_DEPRECATED is only a trap for users.

    Suggested patch below.

    cu
    Adrian


    <-- snip -->


    unconditionally enable SYSFS_DEPRECATED

    This patch unconditionally enables SYSFS_DEPRECATED and schedules it's
    removal for July 2008.

    Currently, SYSFS_DEPRECATED is only a trap for users accidentally
    disabling it.

    In July 2008, all distributions with at least one release a year should
    be able to run without SYSFS_DEPRECATED.

    Signed-off-by: Adrian Bunk <bunk@stusta.de>

    diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt
    index c3b1430..b0bce93 100644
    --- a/Documentation/feature-removal-schedule.txt
    +++ b/Documentation/feature-removal-schedule.txt
    @@ -316,3 +316,13 @@ Why: The option/code is
    Who: Johannes Berg <johannes@sipsolutions.net>

    ---------------------------
    +
    +What: deprecated sysfs files (CONFIG_SYSFS_DEPRECATED)
    +When: July 2008
    +Why: None of these features or values should be used any longer,
    + as they export driver core implementation details to userspace
    + or export properties which can't be kept stable across kernel
    + releases.
    +Who: Greg KH <greg@kroah.com>
    +
    +---------------------------
    diff --git a/init/Kconfig b/init/Kconfig
    index f977086..f652b6f 100644
    --- a/init/Kconfig
    +++ b/init/Kconfig
    @@ -274,24 +274,9 @@ config CPUSETS
    Say N if unsure.

    config SYSFS_DEPRECATED
    - bool "Create deprecated sysfs files"
    + bool
    default y
    help
    - This option creates deprecated symlinks such as the
    - "device"-link, the <subsystem>:<name>-link, and the
    - "bus"-link. It may also add deprecated key in the
    - uevent environment.
    - None of these features or values should be used today, as
    - they export driver core implementation details to userspace
    - or export properties which can't be kept stable across kernel
    - releases.
    -
    - If enabled, this option will also move any device structures
    - that belong to a class, back into the /sys/class heirachy, in
    - order to support older versions of udev.
    -
    - If you are using a distro that was released in 2006 or later,
    - it should be safe to say N here.

    config RELAY
    bool "Kernel->user space relay support (formerly relayfs)"
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-03-06 00:43    [W:0.024 / U:31.536 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site