lkml.org 
[lkml]   [2007]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] KVM: T60 resume fix

* Avi Kivity <avi@qumranet.com> wrote:

> >> That is already CPU_ONLINE in my tree (and in the pull request sent
> >> to Linus a couple of days ago).
> >
> > that solves the resume problem - but doesnt solve the CPU_DEAD issue
> > of sending an IPI to an already offline CPU. Might be a better idea
> > to do it in CPU_DOWN_PREPARE? (and then to also add a
> > CPU_DOWN_FAILED branch?)
>
> Mainline now has DOWN_PREPARE and UP_CANCELED calling
> ->hardware_disable(), and ONLINE calling ->hardware_enabled(). What
> tree are you looking at?

oh, i just hand-fixed it. I'll check current-git now.

> [but I do see the need for DOWN_FAILED now. Off to find a resumable
> machine...]

yeah, both DOWN_FAILED and UP_FAILED might trigger when some other bug
prevents a resume.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-03-05 09:57    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site