lkml.org 
[lkml]   [2007]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 09/11] uml: fix confusion irq early reenabling
    Date
    From: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>

    Fix confusion about call context - comments and code are inconsistent and plain
    wrong, my fault.

    Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
    ---

    arch/um/drivers/line.c | 6 +++---
    1 files changed, 3 insertions(+), 3 deletions(-)

    diff --git a/arch/um/drivers/line.c b/arch/um/drivers/line.c
    index 01d4ab6..f75d7b0 100644
    --- a/arch/um/drivers/line.c
    +++ b/arch/um/drivers/line.c
    @@ -370,10 +370,10 @@ static irqreturn_t line_write_interrupt(int irq, void *data)
    struct tty_struct *tty = line->tty;
    int err;

    - /* Interrupts are enabled here because we registered the interrupt with
    + /* Interrupts are disabled here because we registered the interrupt with
    * IRQF_DISABLED (see line_setup_irq).*/

    - spin_lock_irq(&line->lock);
    + spin_lock(&line->lock);
    err = flush_buffer(line);
    if (err == 0) {
    return IRQ_NONE;
    @@ -381,7 +381,7 @@ static irqreturn_t line_write_interrupt(int irq, void *data)
    line->head = line->buffer;
    line->tail = line->buffer;
    }
    - spin_unlock_irq(&line->lock);
    + spin_unlock(&line->lock);

    if(tty == NULL)
    return IRQ_NONE;

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-05 22:03    [W:0.020 / U:90.740 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site