Messages in this thread | | | Date | Mon, 5 Mar 2007 12:09:20 -0500 | From | "Mike Frysinger" <> | Subject | Re: should RTS init in serial core be tied to CRTSCTS |
| |
On 3/4/07, Russell King <rmk+lkml@arm.linux.org.uk> wrote: > On Thu, Mar 01, 2007 at 07:03:02PM -0500, Mike Frysinger wrote: > > the console= bootcmd allows for controlling of the initial state of > > flow control by adding/omitting the 'r' suffix ... > > The console command *only* sets the state for the kernel's use of one > serial port. It does not affect any other serial port, so tying > random RTS behaviours into that command line option is absolutely > silly.
true ... so ignoring the original motivation for change i posted, is it really correct for the serial core to be forcing TIOCM_RTS at uart startup even though the uart doesnt have CTSRTS flow control enabled ? in other words, my change is agnostic of the console, and is done for all uarts ... it should prob have a similar change in uart_shutdown() though ... -mike - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |