Messages in this thread | | | Date | Mon, 5 Mar 2007 08:25:18 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] highres: Do not run the TIMER_SOFTIRQ after switching to highres mode |
| |
* Andres Salomon <dilinger@debian.org> wrote:
> Thomas Gleixner wrote: > >>> The question is, how the tick timer gets enqueued in the softirq queue. > >>> Can you isolate the codepath, where this happens ? > > > > The TIMER_SOFTIRQ runs the hrtimers during bootup until a usable > > clocksource and clock event sources are registered. The switch to high > > resolution mode happens inside of the TIMER_SOFTIRQ, but runs the > > softirq afterwards. That way the tick emulation timer, which was set up > > in the switch to highres might be executed in the softirq context, which > > is a BUG. The rbtree has not to be touched by the softirq after the > > highres switch. > > > > And an additional request, just to make it explicit that we should not > have any NO_SOFTIRQ callbacks in the tree; BUG out if we encounter > such a thing.
please change it to WARN_ON_ONCE()...
'bug out' might mean: 'dead box'/'no resume'/'no bootup'.
Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |