lkml.org 
[lkml]   [2007]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fix dependency generation
Hi,

On Sat, 31 Mar 2007, Sam Ravnborg wrote:

> The problem is that tristate symbol represent three values.
> =n => CONFIG_SYMBOL is undefined
> =y => CONFIG_SYMBOL is defined
> =m => COMFIG_SYMBOL_MODULE is defined
>
> The function split_config does not take into account the
> different values and 'fixing' this in fixdep is wrong.
> Because fixdep does not know if the variable is a tristate symbol or not
> so it can either blindly remove _MODULE (your patch)
> or each time it encounters _MODULE check for a symbol with and
> without _MODULE.

What really matters is that CONFIG_SYMBOL changed, one could optimize for
the COMFIG_SYMBOL_MODULE case, but I don't think it's worth it, especially
...

> The better fix is to teach the split_config function that
> for tristate symbols two files shall be created in the include/config
> hirachy. So for apm this gets:
> include/config/apm.h
> include/config/apm/module.h

if it requires thousands of new inodes for a feature which should be
rarely used.

> This will make kconfig behave correct the day that someone add a config
> symbol with a _MODULE suffix.

I'd rather reserve that namespace, if it allows for the simpler version to
just map all symbols to the basic config symbol name.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-03-31 18:15    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site