lkml.org 
[lkml]   [2007]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: libata bugfix: preserve LBA bit for HDIO_DRIVE_TASK
Mark Lord wrote:
> Ideally, this would go into linux-2.6.21.
>
> Preserve the LBA bit in the DevSel/Head register for HDIO_DRIVE_TASK.
>
> Signed-off-by: Mark Lord <mlord@pobox.com>
> ---
> --- linux/drivers/ata/libata-scsi.c.orig 2007-03-21
> 13:35:02.000000000 -0400
> +++ linux/drivers/ata/libata-scsi.c 2007-03-30 17:40:58.000000000 -0400
> @@ -333,7 +333,7 @@
> scsi_cmd[8] = args[3];
> scsi_cmd[10] = args[4];
> scsi_cmd[12] = args[5];
> - scsi_cmd[13] = args[6] & 0x0f;
> + scsi_cmd[13] = args[6] & 0x4f;
> scsi_cmd[14] = args[0];
>
> /* Good values for timeout and retries? Values below

IDE seems to be just overriding devsel (0x10) and leaving the rest
alone. Maybe we should do (args[6] & ~0x10) here? Or is it safer this way?

Thanks.

--
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-03-31 05:39    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site