lkml.org 
[lkml]   [2007]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: usb hid: reset NumLock
    Hi Pete,

    On 3/30/07, Pete Zaitcev <zaitcev@redhat.com> wrote:
    >
    > I didn't like a) layering violation, and b) that they defeat filtering
    > unconditionally. Why have any filtering then?
    >
    > Instead, I propose for USB HID driver to reset NumLock on probe. Like this:
    >
    > --- a/drivers/usb/input/hid-core.c
    > +++ b/drivers/usb/input/hid-core.c
    > @@ -458,6 +458,18 @@ static int usb_hidinput_input_event(struct input_dev *dev, unsigned int type, un
    > return 0;
    > }
    >
    > +static void usbhid_set_leds(struct hid_device *hid, unsigned int code, int val)
    > +{
    > + struct hid_field *field;
    > + int offset;
    > +
    > + /* This is often called for the mouse half. */
    > + if ((offset = hidinput_find_field(hid, EV_LED, code, &field)) != -1) {
    > + hid_set_field(field, offset, val);
    > + usbhid_submit_report(hid, field->report, USB_DIR_OUT);
    > + }
    > +}
    > +

    This is fine and that's what we do in atkbd probe but maybe we should
    move that in input core and reset leds as part of
    input_register_device()?

    --
    Dmitry
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-30 20:17    [W:2.917 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site