Messages in this thread | | | Date | Fri, 30 Mar 2007 13:14:58 -0400 | From | Jeff Dike <> | Subject | Re: [PATCH] fix dependency generation |
| |
On Fri, Mar 30, 2007 at 04:43:17PM +0100, Jan Beulich wrote: > >But that will break UM - no?? > >See following note from fixdep: > > * Note 2: if somebody writes HELLO_CONFIG_BOOM in a file, it will depend onto > > * CONFIG_BOOM. This could seem a bug (not too hard to fix), but please do not > > * fix it! Some UserModeLinux files (look at arch/um/) call CONFIG_BOOM as > > * UML_CONFIG_BOOM, to avoid conflicts with /usr/include/linux/autoconf.h, > > * through arch/um/include/uml-config.h; this fixdep "bug" makes sure that > > * those files will have correct dependencies. > > Hmm, didn't see this note. Then this might warrant special casing UML, but > penalizing all code due to this seems at least odd to me.
If I understand this, I would think that special-casing UML_CONFIG_* instead of *_CONFIG_* would be the way to go.
Jeff
-- Work email - jdike at linux dot intel dot com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |