Messages in this thread | | | Subject | Re: usbserial not working/oops on removal | From | Andreas Laumann <> | Date | Sat, 03 Mar 2007 14:27:21 +0100 |
| |
Am Samstag, den 03.03.2007, 11:38 +0100 schrieb Oliver Neukum: > Am Samstag, 3. März 2007 08:19 schrieb Andreas Laumann: > > Am Samstag, den 03.03.2007, 07:45 +0100 schrieb Oliver Neukum: > > > Am Samstag, 3. März 2007 03:37 schrieb Kevin Fenzi: > > > > I'm seeing some oddity with the latest fedora development kernel and a > > > > usbserial device. > > > > > > Very interesting. Is this repeatable? Does unplugging have the same effect? > > > > I see it also on fedora rawhide using reinersct (cyberjack) scard > > readers and it repeatable. > > The first usbserial devices likes to register the line number 255 which > > indeed is invalid. > > OK, please try this patch. > > Regards > Oliver > > --- linux-2.6.21-rc1/drivers/usb/serial/usb-serial.c.alt 2007-02-21 05:32:30.000000000 +0100 > +++ linux-2.6.21-rc1/drivers/usb/serial/usb-serial.c 2007-02-26 15:32:50.000000000 +0100 > @@ -826,7 +826,6 @@ > num_ports = type->num_ports; > } > > - serial->minor = minor; > serial->num_ports = num_ports; > serial->num_bulk_in = num_bulk_in; > serial->num_bulk_out = num_bulk_out; > @@ -980,6 +979,7 @@ > dev_err(&interface->dev, "No more free serial devices\n"); > goto probe_error; > } > + serial->minor = minor; > > /* register all of the individual ports with the driver core */ > for (i = 0; i < num_ports; ++i) {
Unfortunately your fix does not work. The first one seems registered correctly, but after that it fails again for the next one.
usbcore: registered new interface driver usbserial drivers/usb/serial/usb-serial.c: USB Serial support registered for generic usbcore: registered new interface driver usbserial_generic drivers/usb/serial/usb-serial.c: USB Serial Driver core drivers/usb/serial/usb-serial.c: USB Serial support registered for Reiner SCT Cyberjack USB card reader cyberjack 5-2.2:1.0: Reiner SCT Cyberjack USB card reader converter detected usb 5-2.2: Reiner SCT Cyberjack USB card reader converter now attached to ttyUSB0 cyberjack 5-2.3:1.0: Reiner SCT Cyberjack USB card reader converter detected usb-serial ttyUSB0: Error registering port device, continuing usbcore: registered new interface driver cyberjack drivers/usb/serial/cyberjack.c: v1.01 Matthias Bruestle drivers/usb/serial/cyberjack.c: REINER SCT cyberJack pinpad/e-com USB Chipcard Reader Driver
Andreas
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |